Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Max File Size Validator #4

Merged
merged 8 commits into from
Oct 25, 2023
Merged

Max File Size Validator #4

merged 8 commits into from
Oct 25, 2023

Conversation

alecpm
Copy link

@alecpm alecpm commented Oct 18, 2023

This is mostly a back port of the PR here onto our WTA branch. It adds a couple additional fixes (which should probably be added to the original PR):

  • Works for both Image and File upload fields
  • Fixes and issue where a too large file could be uploaded by just re-submitting the form after an initial validation error and keeping the file un-changed (perhaps that's not an issue on Plone 6, not sure if the underlying file widget data handling might have changed).

See washingtontrails/vms#1723

@alecpm alecpm requested a review from davisagli October 18, 2023 22:53
@alecpm alecpm self-assigned this Oct 18, 2023
@davisagli davisagli merged commit 7137fa6 into wta Oct 25, 2023
2 of 3 checks passed
@davisagli davisagli deleted the wta-file-maxsize branch October 25, 2023 18:04
@thet
Copy link

thet commented Mar 12, 2024

@alecpm I updated the original PR with your fix:
collective#411

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davisagli davisagli davisagli approved these changes

Assignees

@alecpm alecpm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alecpm @thet @davisagli @ThibautBorn @mauritsvanrees